-
Notifications
You must be signed in to change notification settings - Fork 109
Transaction free #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Transaction free #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct; updating Private_MarktSQLtTempObject to not create an extended property for the original object if no name is provided.
…alObject NULL, we don't set the extended property tSQLt.Private_TestDouble_OrgObjectName; Messed around with transactions by writing a very good test, but it didn't actually work.
…iscussion in progress on TranName and how we deal with NoTransaction tests; Wrote a test. Yay.
… pass to test the whole NULL thing; Created a failing test. Build continues to be broken.
…nused table, tSQLt.Private_ExpectException; testing skiptest with notransaction and it works (we think).
…QLt.TestMessage --> #TestMessage.
…bleSchema_Expected tables and replaced them with temp tables.
…old file because #consolidation.
…oryTests_SA tests and started working on the code and tests for Private_CleanUp
…for Private_CleanUp
…for Private_CleanUp, we also need the ssmssqlproj files so that the files show up in SSMS (deprecated).
…into TransactionFree
…tionTableAction and Private_ResettSQLtTable(s) to Private_NoTransactionHandleTable(s).
…the Tests project.
… build worked and now it fails.
… Reset/Error condition, Ignore, Truncate, and Remove.
…ic to raise an error if the @Result of a test is Abort; Added more test todos
… we are just going to change it again. Yay!
…nction. At least one is failing.
…es and their related Statuses; Updated both views to enforce specific column definitions;
…leanUpCmdHandler; Completed(!?) tests for Private_HandleMessageAndResult; More AnnotationNoTransactionTests.
…n broke some tests.
… within an inner no-transaction test <-- we have no issues when the inner test is not a no-transaction test and we should include this test in the test class.
…ction (BEGIN TRAN) only within a try-catch block invalidating the transaction.
trying to manually revert back to desired version
Transaction free20211219
…l based on learnings around the try-catch w/transactions defect
…for Private_NoTransactionHandleTable and confirmed that we are done with this functionality (for now).
Updating service principal
updating to test a manually created service principal
Updated service principal again
Catching up on fixes to the Azure DevOps pipeline.
mbt1
approved these changes
Dec 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
122 commits later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.